[Wasm RyuJIT] Implement contained bitcast operands#128472
Merged
Merged
Conversation
kg
added
arch-wasm
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Wasm RyuJIT codegen to handle GT_BITCAST nodes whose operand is marked as contained (previously this path was NYI_WASM), so bitcasts of stack locals can be emitted without requiring a separate standalone operand node.
Changes:
- Replace the
NYI_WASM("Contained bitcast operands")fallback inCodeGen::genCodeForBitCastwith codegen for a containedGT_LCL_VARoperand.
adamperlin
approved these changes
May 22, 2026
Member
Author
|
/ba-g dotnet/sdk#54350 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses an issue hit in #128382